Joined: 10/6/2011
Posts: 1697
Location: RU · ID · AM
Why not to set display_errors to be off? It’s the production site, I beleive it’s normal solution in this case.
Also, just for your info, in my code I always filter all request variables and allow to be arrays only those of them which are supposed to be arrays.
S3&A [Amy amy%] improvement (with Evil_3D & kaan55) — currently in SPZ2
my TAS channel · If I ever come into your dream, I’ll be riding an eggship :)
If you rate a movie without giving a rating to one of the categories, it lowers your average score. How come? I was going to rate movies only on entertainment, but it seems that I'm bringing down movie ratings unfairly.
Fixed. It erroneously regarded missing ratings as zero ratings when computing the average for that user / movie.
Edit:
Bug I noted in user movies (causes need to be determined): The World of Goo submission file can't be uploaded.
It seems that the POST variables are not received for some reason??? Because the file is too large?
Edit2:
Worked around that by allowing uploads of movies inside .zip. Won't fix the root cause (would need streaming upload code) but allows uploading stuff that previously couldn't be uploaded.
On the main page news module, can we please get proper links behind the headlines?
I tried middle-clicking the headline to open the post in a new tab, but since it's not actually a link, it didn't work.
change
<h3 style="cursor:pointer;" onmouseover="this.style.textDecoration='underline';" onmouseout="this.style.textDecoration='none';" onclick="document.getElementById('post_323367').style.display='';">Official WIP movie storage</h3>
to
<h3><a href="http://tasvideos.org/forum/viewtopic.php?p=323367#323367" onclick="document.getElementById('post_323367').style.display='';return false;">Official WIP movie storage</a></h3>
and left-clicking should work as before, while middle-clicking should start working as expected.
Joined: 3/9/2004
Posts: 4588
Location: In his lab studying psychology to find new ways to torture TASers and forumers
I absolutely hate it when sites do that, especially using an a tag which doesn't actually go anywhere, and you get a new tab with JavaScript in it. I've gone around fixing such silliness in different parts of the site.
I fixed it here too, and it should be live on the site soon. Thanks for the report.
Warning: Opinions expressed by Nach or others in this post do not necessarily reflect the views, opinions, or position of Nach himself on the matter(s) being discussed therein.
Thank you. Though the links now look differently (blue instead of black); if that wasn't intended, some css rules are required.
.newsfloat h3 a { color: black; text-decoration: none; }
.newsfloat h3 a:hover { text-decoration: underline; }
and the click-handler could be changed into
var s=document.getElementById('post_323367').style;s.display = s.display=='none'?'':'none';
or something so you can close the news again.
But meh, minor nitpicks. Thanks!
Looks like it is the '!' in one of the URL paths that breaks stuff (rendering the entire post invisible).
Escaping it as %21 seems to work (even if URL syntax doesn't seem to require it).
Also, the following characters in URLs break the post: *, ', ( and ). The escape codes are %2a, %27, %28 and %29 (in order).
Joined: 3/9/2004
Posts: 4588
Location: In his lab studying psychology to find new ways to torture TASers and forumers
I'll see what I can do. Thanks for the report.
Warning: Opinions expressed by Nach or others in this post do not necessarily reflect the views, opinions, or position of Nach himself on the matter(s) being discussed therein.
A minor bug: This post looks normal in the thread I posted it in, but the hyperlink does not end on the search page for posts by CoolKirby. This might cause other links in a post to lose their link locations, at least on the search page.
The HTML of the search page just moves the </a> at the end of "HxD" to the end of the post. It seems like it should be easy to fix.
1) Trying to add https mirror link results in error message about having multiple mirrors from the same site.
1-a) This occurs even if there aren't any mirrors already.
1-b) This occurs even for users that have privilege to override the multiple mirror check.
2) Trying to replace mirror with https mirror link results in mirror being deleted with no replacement.
2-a) Even if this is the last mirror and user doesn't have privileges to bring mirror count to zero.
3) One can publish a movie with https:// mirror link entered... Resulting a publication with no mirrors.
This was noticed as apparently recently archive.org started offering https links (the collection pages on https://archive.org/details/ links to https URLs for files).
* Resulting in such URLs to be put as mirror URLs and torrent webseed URLs.
* HTTPS torrent webseed URLs have their own problems (but that's not a site bug).
How to fix this (there are multiple different ways)?
1) Allow HTTPS links, treating http://foo.example/ and https://foo.example/ as different.
2) Allow HTTPS links, treating http://foo.example/ and https://foo.example/ as the same.
3) Add explicit check against adding non-HTTP links, so those can be rejected early.
Unfortunately, fixing it isn't trivial:
- If one disables tiling, it looks bad.
- Extending the image isn't that simple either, because the background is not quite a vertical gradient (trying to use copy'n'paste to extend it causes seams).
Joined: 10/6/2011
Posts: 1697
Location: RU · ID · AM
For some reason my download speed from archive.org is 3–4 times less than from european servers. It’s actually not a website’s problem, it’s a problem of international link between Russia and USA, I think…
Link to video
This is not a bug report in any way, just an observation, didn’t know where to post it…
P.S.: yes, I prefer BitTorrent, again, this is just an observation.
S3&A [Amy amy%] improvement (with Evil_3D & kaan55) — currently in SPZ2
my TAS channel · If I ever come into your dream, I’ll be riding an eggship :)
Oh, nice finding of very subtle bug.
It is not fixed yet. And it is not game page specific problem. I just reproduced the problem on a subpage of my homepage. Even the links to other wiki pages break.
I know what is going on: The movie module is aggressively cached[1], but involves relative links, which usually break if the "depth" changes (especially if it increases). Normally movie module only appears on "depth 0" (http://tasvideos.org/foo.html), but the game pages put it on "depth 1" (http://tasvideos.org/foo/bar.html). But the game pages aren't the only way "depth 1" (or even greater depths) can appear: You get that too if you put it on a subpage.
Edit: Did a slightly nasty hack to work around the problem...
[1] The entire HTML of the resulting box is cached.
<klmz> it reminds me of that people used to keep quoting adelikat's IRC statements in the old good days
<adelikat> no doubt
<adelikat> klmz, they still do
I think the code gets duplicate entries from the database in certain situations, but I don't remember the details. (The fix would be to merge duplicates in said code.)