Question: What's the "best" way to store a collection of strings within the script architecture (NOT asking "What data struct I should use" since that's forced to be "Array of Strings")? Should I split that off into a separate file specifically for definitions like that or dedicate a section of the script for said Array of Strings?
It depends on what you are trying to do. Explain more... Are the strings already done before the script starts, or they are generated after, by the user or the game? Is this collection way too big?
Sorry for asking this again, but I'm having a bad time with those functions: string forms.getproperty(int handle, string property) void forms.setproperty(int handle, string property, object value) Whenever I try to get a property, the console writes: Object reference not set to an instance of an object. And when I try to set the property of a checkbox (or buttons etc), during the creation of a form, it doesn't work, giving: LuaInterface.LuaScriptException: <value> Therefore, I don't know what property is and what the value object is. Can someone illuminate me here? I just wanted to checkbox the default options, without the player having to press each one everytime they initiate a script.
Language: lua-- Get the status of a checkbox -- the same task of forms.ischecked local status = forms.getproperty(checkbox_handle, "CheckState") print(status) --> "Checked" or "Unchecked" -- Set the status of a checkbox forms.setproperty(checkbox_handle, "Checked", true) -- or false to force an uncheck
More screenshots: http://imgur.com/a/mxwsI
Download: https://github.com/rodamaral/smw-tas/wiki/Downloads
Commentaries, criticism (specially bug reports, lsnes has 4K lines!) are welcome. Tips on how to use git and distribute this correctly too.which fails because table.getn(keysArray) returns 0. Is there another way to check table length that I've overlooked, or is the table library not implemented or am I just being a dumb?Language: luacheckTime = 0 buttonsPressed = 0 function core() checkTime = emu.framecount() % 10 if (checkTime == 0) then sendRandomButtonPress() end end function sendRandomButtonPress() keysArray = joypad.get(1) i = math.random(table.getn(keysArray)) keysArray[i] = "True" joypad.set(keysArray,1) buttonsPressed = buttonsPressed + 1 end event.onframestart(core)
which fails because table.getn(keysArray) returns 0. Is there another way to check table length that I've overlooked, or is the table library not implemented or am I just being a dumb?
Language: lualocal keys = joypad.get(1); local count = 1; chosen = nil; for k,v in pairs(keys) do if math.random(count) == 1 then chosen = k; end count = count + 1; end keys[chosen] = true;
gui.text(0, 10, 'Flash obtained','RED')
Edit:
Nevermind, I'm stupid. That was the arguement for background. >.<So now this is working more-or-less as intended; Power gets blacklisted outright, and I haven't tried it with multidisk mode yet so there may be more blacklisting. Right now, I'm curious to find out why it sends multiple button presses - it's currently sending two buttons with each update. My current guess is because the key state table (keysArray) isn't actually getting reset between calls. Still, it is at least able to get massacred by Gary in 1P pokemon, so it's more progress than I had this time last week.Language: luacheckTime = 0 buttonsPressed = 0 keyNames = {} keysArray = {} function core() checkTime = emu.framecount() % 10 if (checkTime == 0) then sendRandomButtonPress() end end function sendRandomButtonPress() keysArray = joypad.get() i = math.random(table.getn(keyNames)) push = keyNames[i] if push ~= "Power" and push ~= "P1 Power" and push ~= "P2 Power" then keysArray[push] = "True" end joypad.set(keysArray) buttonsPressed = buttonsPressed + 1 end function getButtonNames() k = 1 for i,v in pairs(joypad.get())do keyNames[k] = i k = k+1 end end getButtonNames() event.onframestart(core)
Right now, I'm curious to find out why it sends multiple button presses - it's currently sending two buttons with each update. My current guess is because the key state table (keysArray) isn't actually getting reset between calls.
Language: luaevent.unregisterbyname("some-fancy-name-onframestart") -- deletes the first registered function with this name event.onframestart(core, "some-fancy-name-onframestart") -- registers core, on frame start, with this name
Language: luaccheckTime = 0 buttonsPressed = 0 keyNames = {} keysArray = {} blacklist = {"Power", "Reset"} frequency = 10 function core() checkTime = emu.framecount() % frequency if (checkTime == 0) then sendRandomButtonPress() elseif (checkTime < frequency/2) then joypad.set(keysArray) end end function sendRandomButtonPress() keysArray = joypad.get() i = math.random(table.getn(keyNames)) push = keyNames[i] if checkBlacklist(push) == true then keysArray[push] = "True" end joypad.set(keysArray) buttonsPressed = buttonsPressed + 1 end function getButtonNames() k = 1 for key,v in pairs(joypad.get()) do keyNames[k] = key k = k+1 end end function checkBlacklist(key) result = true for i, v in pairs(blacklist) do if key == blacklist[i] then result = false end end return result end function initializeKeyArray() keysArray = joypad.get() end getButtonNames() initializeKeyArray() while true do core() emu.frameadvance() end
Language: lua-- PRNG BOT version 2 (Greentext) -- Changes (2015-11-07): -- P1 and P2 are now independently checked rather than just using the global joypad.get() results. -- This makes blacklisting less of a chore as joypad.whatever, when passed a player number, -- actually omits the player number prefix. -- The upshot is that perfecting the Blacklist is a little easier. -- -- Also, I removed the Buttons Pressed counter. It was not seeing any practical use. -- It was originally a debug variable, but I ended up debugging using the console anyway. -- -- Also also, documentation. This is the Greentext Update. -- Global variable declarations -- checkTime = 0 -- Placeholder variable. I don't like passing expressions as arguments. keyNamesP1 = {} -- Player 1 Key Names array. keysArrayP1 = {} -- Player 1 Key State array. keyNamesP2 = {} -- Player 2 Key Names array. keysArrayP2 = {} -- Player 2 Key State array. blacklist = {"Power", "Reset"} -- Blacklisted keys array. frequency = 10 -- How often should the bot be updating? Also influences how long the keys are held. mplay = false -- Is there a P2 controller? If not, we don't want to bother mucking around with P2 stuff. function core() -- I like to have a manager functon that only handles calling other functions. checkTime = emu.framecount() % frequency -- Set the frame count checker to the frame count modulo the frequency. if (checkTime == 0) then -- If we're on the right frame, then go ahead and generate a new random key. sendRandomButtonPressP1() -- For the technically-minded, it's actually pseudorandom, but let's not be overly pedantic. if mplay == true then -- If Player 2's controller exists, generate keypresses for it as well. sendRandomButtonPressP2() end elseif (checkTime < frequency/2) then -- Now, not all games accept single-frame inputs. joypad.set(keysArrayP1,1) -- One of the games I tested with had this problem. if mplay == true then -- So, for half of the frames between new keypress generations, send the same presses. joypad.set(keysArrayP2,2) -- This allows 'slower' games to keep up, though it also slows down high-precision games. end -- But do you really want to use a PRNG with a high-precision game? end end function getButtonNames() -- Scraping joypad.get(x) for key names. k = 1 j = 1 for key,v in pairs(joypad.get(1)) do -- For each pair in joypad.get(x) keyNamesP1[k] = key -- keyNamesPX in position k is assigned key... uhh, key. k = k+1 -- and k is incremented. end if joypad.get(2) ~= nil then -- As long as there's a table for P2, do the same for P2. for key,v in pairs(joypad.get(2)) do keyNamesP2[j] = key -- This can be rewritten to use one less for loop. j = j+1 -- However, I like it written this way since it's one less if-then than would be needed. mplay = true -- Since boolean mplay starts false, we set it true. end -- This allows me to tell other functions to skip the P2 stuff if there's no P2. end end function sendRandomButtonPressP1() -- So let's look at sending random keys to player 1's controller. keysArrayP1 = joypad.get(1) -- First, fetch the current keys array. i = math.random(table.getn(keyNamesP1)) -- Generate a random number between 1 and the length of the Player 1 Key Names Array. push = keyNamesP1[i] -- Grab the key referenced by the generated random number. if checkBlacklist(push) == true then -- If the key is not blacklisted, keysArrayP1[push] = "True" -- then set the key to be pressed. end joypad.set(keysArrayP1,1) -- Finally, send the keys array to BizHawk for pressing. end function sendRandomButtonPressP2() -- This is a doublicate of the P1 variant. keysArrayP2 = joypad.get(2) -- Technically, these can be rewritten as a single function with clever argument use. i = math.random(table.getn(keyNamesP2)) -- It's on the docket for the next revision. push = keyNamesP2[i] if checkBlacklist(push) == true then keysArrayP2[push] = "True" end joypad.set(keysArrayP2,2) end function checkBlacklist(key) -- Long story short, certain keys (such as the power button) shouldn't be pressed. result = true for i, v in pairs(blacklist) do if key == blacklist[i] then -- Check to make sure the button is not on the blacklist. result = false -- If it's on the blacklist, DO NOT PRESS THE BUTTON. end end return result end function initializeKeyArray() -- Just taking the key names and putting them into our placeholder arrays. keysArrayP1 = joypad.get(1) -- We don't actually need to do this now, as they're reinitialized every time keys are sent. if mplay == true then -- It's just best practice to initialize variables before using them. keysArrayP2 = joypad.get(2) -- With that said, I do call the arrays before they get defined otherwise. end -- I can't remember if I actually tested without this function. end ---------------------------------------- AND NOW, FOR THE ACTUAL FUNCTION CALLS getButtonNames() initializeKeyArray() while true do core() emu.frameadvance() end
So I've run into an interesting issue. joypad.get(1) returns nil if there's only one controller in the core. Easy way to see this is to call it in the Gambatte core. Why is this interesting?
E: So, the upshot is now I'm going to be requesting a new joypad function: joypad.countPlayers(). Should just return the number of controllers the core will accept inputs for at that time - example, if in N64 mode you have it set up for three controllers, joypad.countPlayers() should return 3.Language: lua-- PRNG BOT version 3 (Refraction) -- Just rewriting some variables and sendRandomButtonPress to allow for on-the-fly expansion up to five(!?) players in future updates. -- TODO: return-nil kludge, learn and implement forms. Prepare other functions for on-the-fly expansion. -- Global variable declarations -- checkTime = 0 -- Placeholder variable. I don't like passing expressions as arguments. keyNames = {[1] = {},[2] = {}} -- Key Names array. keysArray = {[1] = {},[2] = {}} -- Key State array. blacklist = {"Power", "Reset"} -- Blacklisted keys array. frequency = 10 -- How often should the bot be updating? Also influences how long the keys are held. mplay = false -- Is there a P2 controller? If not, we don't want to bother mucking around with P2 stuff. function core() -- I like to have a manager functon that only handles calling other functions. checkTime = emu.framecount() % frequency -- Set the frame count checker to the frame count modulo the frequency. if (checkTime == 0) then -- If we're on the right frame, then go ahead and generate a new random key. sendRandomButtonPress(1) -- For the technically-minded, it's actually pseudorandom, but let's not be overly pedantic. if mplay == true then -- If Player 2's controller exists, generate keypresses for it as well. sendRandomButtonPress(2) end elseif (checkTime < frequency/2) then -- Now, not all games accept single-frame inputs. joypad.set(keysArray[1],1) -- One of the games I tested with had this problem. if mplay == true then -- So, for half of the frames between new keypress generations, send the same presses. joypad.set(keysArray[2],2) -- This allows 'slower' games to keep up, though it also slows down high-precision games. end -- But do you really want to use a PRNG with a high-precision game? end end function getButtonNames() -- Scraping joypad.get(x) for key names. k = 1 j = 1 for key,v in pairs(joypad.get(1)) do -- For each pair in joypad.get(x) keyNames[1][k] = key -- keyNamesPX in position k is assigned key... uhh, key. k = k+1 -- and k is incremented. end if joypad.get(2) ~= nil then -- As long as there's a table for P2, do the same for P2. for key,v in pairs(joypad.get(2)) do keyNames[2][j] = key -- This can be rewritten to use one less for loop. j = j+1 -- However, I like it written this way since it's one less if-then than would be needed. mplay = true -- Since boolean mplay starts false, we set it true. end -- This allows me to tell other functions to skip the P2 stuff if there's no P2. end end function sendRandomButtonPress(player) -- So let's look at sending random keys to player 1's controller. keysArray[player] = joypad.get(player) -- First, fetch the current keys array. i = math.random(table.getn(keyNames[player])) -- Generate a random number between 1 and the length of the Player 1 Key Names Array. push = keyNames[player][i] -- Grab the key referenced by the generated random number. if checkBlacklist(push) == true then -- If the key is not blacklisted, keysArray[player][push] = "True" -- then set the key to be pressed. else sendRandomButtonPress(player) end joypad.set(keysArray[player],player) -- Finally, send the keys array to BizHawk for pressing. end function checkBlacklist(key) -- Long story short, certain keys (such as the power button) shouldn't be pressed. result = true for i, v in pairs(blacklist) do if key == blacklist[i] then -- Check to make sure the button is not on the blacklist. result = false -- If it's on the blacklist, DO NOT PRESS THE BUTTON. end end return result end function initializeKeyArray() -- Just taking the key names and putting them into our placeholder arrays. keysArray[1] = joypad.get(1) -- We don't actually need to do this now, as they're reinitialized every time keys are sent. if mplay == true then -- It's just best practice to initialize variables before using them. keysArray[2] = joypad.get(2) -- With that said, I do call the arrays before they get defined otherwise. end -- I can't remember if I actually tested without this function. end ---------------------------------------- AND NOW, FOR THE ACTUAL FUNCTION CALLS getButtonNames() initializeKeyArray() while true do core() emu.frameadvance() end
E: So, the upshot is now I'm going to be requesting a new joypad function: joypad.countPlayers(). Should just return the number of controllers the core will accept inputs for at that time - example, if in N64 mode you have it set up for three controllers, joypad.countPlayers() should return 3.
EDIT: it doesn't count possible unconnected controllers.Language: luafunction joypad.countPlayers() -- returns the highest argument joypad.get(arg) can have / or nil if arg == 1 returns nil or an empty table local next = next local MAX = 100 for count = 1, MAX do local joyget = joypad.get(count) if (joyget == nil or next(joyget) == nil) then if count == 1 then return nil else return count - 1 end end count = count + 1 if count == MAX then error"joypad.countPlayers: something went wrong" end -- sanity check end end
Language: lua-- PRNG BOT version 4 (Amaraticando) -- Special thanks to Amaraticando, for the countPlayers() function. -- -- No longer fails for single-controller games, AND works for up to 100 controllers! -- Well, it's only been tested up to four controllers BUT IT WORKS! And it should work for up to 100 controllers. -- TODO: Learn and implement forms. -- Global variable declarations -- checkTime = 0 -- Placeholder variable. I don't like passing expressions as arguments. keyNames = {} -- Key Names array. keysArray = {} -- Key State array. blacklist = {"Power", "Reset"} -- Blacklisted keys array. frequency = 10 -- How often should the bot be updating? Also influences how long the keys are held. mplay = false -- Is there a more than one controller? If not, there's special handling that needs to happen. function core(mode) cap = countPlayers() -- I like to have a manager functon that only handles calling other functions. checkTime = emu.framecount() % frequency -- Set the frame count checker to the frame count modulo the frequency. if (checkTime == 0) then -- For the technically-minded, it's actually pseudorandom, but let's not be overly pedantic. if mode == true then -- If we have multiple controllers connected, for i=1,cap do -- then for each connected controller sendRandomButtonPress(i) -- send a random button press. end else -- if there is only one connected controller sendRandomButtonPress() -- send a random button press. end elseif (checkTime < frequency/2) then if mode == true then -- Now, not all games accept single-frame inputs. for j=1,cap do joypad.set(keysArray[j],j) -- So, for half of the frames between new keypress generations, send the same presses end -- But do you really want to use a PRNG with a high-precision game? else joypad.set(keysArray) end end end function countPlayers() -- returns the highest argument joypad.get(arg) can have / or nil if arg == 1 returns nil or an empty table local next = next -- Written by Amaraticando local MAX = 100 for count = 1, MAX do local joyget = joypad.get(count) if (joyget == nil or next(joyget) == nil) then if count == 1 then return nil else return count - 1 end end count = count + 1 if count == MAX then error"joypad.countPlayers: something went wrong" end -- sanity check end end function getButtonNames(mode) -- Scraping joypad.get(x) for key names. if mode == true then -- If there are multiple controllers connected, for i=1, countPlayers() do -- then for each controller keyNames[i] = {} -- make a new array in the key names array, k = 1 for key in pairs(joypad.get(i)) do -- and for each button on the controller keyNames[i][k] = key -- add it to the key names array. k = k + 1 -- DYNAMICALLY NESTED ARRAYS! end end else k = 1 for key in pairs(joypad.get()) do -- If there's only one controller connected, keyNames[k] = key -- then for each button on the controller k = k + 1 -- and add it to the key names array. end end end function sendRandomButtonPress(player) if player ~= nil then -- So let's look at sending random keys to the controller. keysArray[player] = joypad.get(player) -- First, fetch the current keys array. i = math.random(table.getn(keyNames[player])) -- Generate a random number between 1 and the length of the Key Names Array. push = keyNames[player][i] -- Grab the key referenced by the generated random number. if checkBlacklist(push) == true then -- If the key is not blacklisted, keysArray[player][push] = "True" -- then set the key to be pressed. else -- If the key is blacklisted, sendRandomButtonPress(player) -- then just pick a new key. end joypad.set(keysArray[player],player) -- Finally, send the keys array to BizHawk for pressing. else keysArray = joypad.get() -- Since joypad.get(1) returns nil if the core can only have one controller, i = math.random(table.getn(keyNames)) -- special handling has to be done for such cases. push = keyNames[i] if checkBlacklist(push) == true then keysArray[push] = "True" else sendRandomButtonPress() end joypad.set(keysArray) end end function checkBlacklist(key) -- Long story short, certain keys (such as the power button) shouldn't be pressed. result = true for i, v in pairs(blacklist) do if key == blacklist[i] then -- Check to make sure the button is not on the blacklist. result = false -- If it's on the blacklist, DO NOT PRESS THE BUTTON. end end return result end function initializeKeyArray() -- Just taking the key names and putting them into our placeholder arrays. cap = countPlayers() if cap == nil then mplay = false -- This is also when we determine if the core only expects a single controller. keysArray = joypad.get() else mplay = true for i=1, cap do keysArray[i] = joypad.get(i) end end end ---------------------------------------- AND NOW, FOR THE ACTUAL FUNCTION CALLS initializeKeyArray() getButtonNames(mplay) while true do core(mplay) emu.frameadvance() end