1 2
9 10 11
15 16
Former player
Joined: 8/1/2004
Posts: 2687
Location: Seattle, WA
I'm loving your program so far, Maximus. My only qualm is that it seems to drop L/R inputs for GBA vbm files. When I load GBA vbm files, TASHex tells me that it is a GB vbm, not GBA. I guess that makes TASHex assume that shoulder buttons are not a factor. Any idea why that is? This happens to 80% of my splice attempts, and it seems like vbms from outdated VBA builds don't have this problem.
hi nitrodon streamline: cyn-chine
Joined: 4/11/2006
Posts: 487
Location: North of Russia :[
Tashex and this editor are two different things `^_^ and tashex works fine with vbms :)
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Zurreco wrote:
I'm loving your program so far, Maximus. My only qualm is that it seems to drop L/R inputs for GBA vbm files. When I load GBA vbm files, TASHex tells me that it is a GB vbm, not GBA. I guess that makes TASHex assume that shoulder buttons are not a factor. Any idea why that is? This happens to 80% of my splice attempts, and it seems like vbms from outdated VBA builds don't have this problem.
I'm not entirely sure what the issue is here, but I'll look into it a bit further. Zefiris, you're responding a lot in this topic ... maybe we should team up and write something awesome (no .NET, no Delphi .... we'll meet somewhere in the middle :P)
Former player
Joined: 8/1/2004
Posts: 2687
Location: Seattle, WA
Righto. Maximus' editor is giving me the problems, not TASHex. If you need the vbms for testing, just ask.
hi nitrodon streamline: cyn-chine
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Zurreco wrote:
Righto. Maximus' editor is giving me the problems, not TASHex. If you need the vbms for testing, just ask.
If you could toss em up on microstorage or email them to me, i'll take a look. I've had VBM issues in the past as well, so there's definitely something going on here (or, in this case, not going on :P)
Joined: 4/11/2006
Posts: 487
Location: North of Russia :[
No, we should not, any project we start together is doomed :( a) I am lazy b) You have already big project, and starting from scratch is no fun, really. c) insert any reason I forgot here `^^ Your editor is awesome already :) It's up to you to make it flawless, everyone is helping with pointing out different bugs :) nobody would notice if nobody used or needed it :) (Why all those words? I REALLY don't want you to abandon this project like I always do if something goes wrong or program is "already usable, but a little glitchy, who cares?")
Former player
Joined: 3/23/2006
Posts: 211
Incase anyone else tries doing this... I just spent five hours trying to get this to run on linux with mono. I managed to compile it from source (with a few modifications, eg removing references to the icons as I couldn't figure out how to embed them in the .exe with the right IDs), but now it fails with: System.ArgumentOutOfRangeException: Argument is out of range. Parameter name: index at System.Windows.Forms.TreeNodeCollection.get_Item (Int32 index) (then the whole stack trace comes here) by putting Console.WriteLines in I've found that this happens on the line Application.Run(new frmMain()); in Program.cs (in the Application.Run bit to be specific) I'm giving up for the moment.
do not forget to *ENJOY THE SAUCE*
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Huffers, I think mono is still a little touchy with System.Windows.Forms, so if the treeview is giving you problems, just comment out the view population call in frmMain.cs.
/// <summary>
/// Loads a TAS into the editor
/// </summary>        
private void loadMovie(string filename, bool fromRecent)
{            
	...
	
	// load the movie object up with the correct format and display a thumbnail
	switch (FrameData.Format)
	{                
		case MovieType.SMV:
			Movie = new SNES9x(filename);
			//Methods.PopulateMovieInfo.SMV(ref tvInfo, ref Movie);
			pbFormat.Image = ((System.Drawing.Icon)(rm.GetObject("icon_smv"))).ToBitmap();
			break;
		case MovieType.FCM:
			Movie = new FCEU(filename);
			//Methods.PopulateMovieInfo.FCM(ref tvInfo, ref Movie);
			pbFormat.Image = ((System.Drawing.Icon)(rm.GetObject("icon_fcm"))).ToBitmap();
			break;
		case MovieType.GMV:
			Movie = new Gens(filename);
			//Methods.PopulateMovieInfo.GMV(ref tvInfo, ref Movie);
			pbFormat.Image = ((System.Drawing.Icon)(rm.GetObject("icon_gmv"))).ToBitmap();
			break;
		case MovieType.FMV:
			Movie = new Famtasia(filename);
			//Methods.PopulateMovieInfo.FMV(ref tvInfo, ref Movie);
			pbFormat.Image = ((System.Drawing.Icon)(rm.GetObject("icon_fmv"))).ToBitmap();
			break;
		case MovieType.VBM:
			Movie = new VisualBoyAdvance(filename);
			//Methods.PopulateMovieInfo.VBM(ref tvInfo, ref Movie);
			pbFormat.Image = ((System.Drawing.Icon)(rm.GetObject("icon_vbm"))).ToBitmap();
			break;
		case MovieType.M64:
			Movie = new Mupen64(filename);
			//Methods.PopulateMovieInfo.M64(ref tvInfo, ref Movie);
			pbFormat.Image = ((System.Drawing.Icon)(rm.GetObject("icon_m64"))).ToBitmap();
			break;
		case MovieType.None:
			resetApplication();
			return;
	}
	
	...
}
Former player
Joined: 3/23/2006
Posts: 211
Maximus wrote:
Huffers, I think mono is still a little touchy with System.Windows.Forms, so if the treeview is giving you problems, just comment out the view population call in frmMain.cs.
Hey, thanks for the help... but now I get: System.InvalidOperationException: Operation is not valid due to the current state of the object at System.Windows.Forms.ListView+ListViewItemCollection.GetEnumerator () (...etc) Ugh. I think I'll just write a Python script to automate my SMV splicing.
do not forget to *ENJOY THE SAUCE*
Joined: 4/11/2006
Posts: 487
Location: North of Russia :[
Try TASHex? There is linux version...
Former player
Joined: 3/23/2006
Posts: 211
zefiris wrote:
Try TASHex? There is linux version...
Found it, this looks perfect :)
do not forget to *ENJOY THE SAUCE*
Joined: 4/11/2006
Posts: 487
Location: North of Russia :[
It's kind of off-topic, but I am glad `^___^
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
zefiris wrote:
It's kind of off-topic, but I am glad `^___^
Go off topic all you want, it makes this topic look more popular than it really is :P
Former player
Joined: 8/1/2004
Posts: 2687
Location: Seattle, WA
For a quick example of what I'm talking about: I made this quick movie file because it shows a quick use of L and R to do tricks. I then loaded the vbm in the TAS Editor, which recognized it as a GB file (not GBA). Without changing anything from the original, I saved the TAS Editor's version of the vbm as this file. You'll see that the tricks are not pulled off, obviously. So uh, have a field day with it. If other people aren't having this problem, I guess it's an error on my part. However, I don't see why the editor would assume that my vbms are GB oriented, rather than what VBA deems it. Maybe a quick fix would be to have the editor assume that all vbm files can use the GBA's inputs(A B L R < > /\ \/ S s). That way, GBA is covered, and GB/GBC simply won't be affected by L R inputs. Just a thought.
hi nitrodon streamline: cyn-chine
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Zurreco, Finally got a chance to look into this, and it turns out that it's the stupidest oversight in the history of oversights (on my part at least) :P For some reason, I was ORing the two bytes together to compare them, so basically I would never be able to detect L/R input. This has been fixed. I'm just cleaning some other stuff up, then should release a fix (finally, VBM WILL WORK!!!!). As for the graphical input .... more than likely this won't make the cut for this release. I just can't get it to work efficiently, so I'll likely have to write my own subclass of ListView and ListViewItem if this is ever going to happen. Personally though, I don't really see it as necessary, but enough people have expressed an interest, so it's still going to happen ... eventually :)
Active player (411)
Joined: 3/16/2004
Posts: 2623
Location: America, Québec
It would be nice if we could edit "Author info" and/or "Author comments" with this tool. Can you do that?
Former player
Joined: 8/1/2004
Posts: 2687
Location: Seattle, WA
Phil wrote:
It would be nice if we could edit "Author info" and/or "Author comments" with this tool. Can you do that?
Those fields become changeable when you're saving the new input file.
hi nitrodon streamline: cyn-chine
Active player (411)
Joined: 3/16/2004
Posts: 2623
Location: America, Québec
Ah, strange. I wouldn't find it if you you weren't there. Maybe something more user-friendly? Also, the application refuses to save the file and there is an error.
See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at MovieSplicer.Data.Formats.FCEU.getRLELength(TASMovieInput[]& input)
   at MovieSplicer.Data.Formats.FCEU.Save(String filename, TASMovieInput[]& input)
   at MovieSplicer.UI.frmSaveAs.btnSave_Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
tas-movie-editor
    Assembly Version: 0.9.2.0
    Win32 Version: 0.9.2.0
    CodeBase: file:///G:/Timeattack%20en%20cours/Tas%20movie%20editor/tas-movie-editor.exe
----------------------------------------
System.Windows.Forms
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system>
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.


So, what's going on?
Joined: 8/27/2006
Posts: 883
Only a little mistake, it might be two problem, he lost a reference of the object, or he forget to instanciate it, in any case, it could be solves in a couple of minutes :P
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Hrm, seems there's something wonky going on Phil. I'll look into it shortly. Sadly, shortly could take some time ... my trustworthy main drive finally died on me, so i'm in the process of getting myself back up and running on a new drive. Decided to go with the new Ubuntu 7.04, just for kicks (gonna see if i can maintain an isolated dev environment using VMWare ... stupid windows ... stupid viruses). I'll hopefully be up and running by the end of the weekend.
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Phil wrote:
Ah, strange. I wouldn't find it if you you weren't there. Maybe something more user-friendly?
What would you proposed as more user-friendly?
Player (105)
Joined: 1/30/2005
Posts: 564
Location: Québec, Canada
I don't know if this has been brought up before, but TAS Movie Editor doesn't work with movies made using Snes9x 1.51. Would it be possible to add support for those kinds of movies too? Also, I noticed that the program will make a complicated error message box (much like the one mentionned above) when you try to save the file while the emulator still has it open. For example, let's say I watch a movie in Snes9x 1.43, and then I pause it, go to modify something using TAS Movie Editor, and then try to save it, it'll show a weird error. That's probably a read-only thing. Hope that helps solve / manage some errors! Continue your great work on this, it's proving to be a very useful tool!
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Halamantariel wrote:
I don't know if this has been brought up before, but TAS Movie Editor doesn't work with movies made using Snes9x 1.51. Would it be possible to add support for those kinds of movies too? Also, I noticed that the program will make a complicated error message box (much like the one mentionned above) when you try to save the file while the emulator still has it open. For example, let's say I watch a movie in Snes9x 1.43, and then I pause it, go to modify something using TAS Movie Editor, and then try to save it, it'll show a weird error. That's probably a read-only thing. Hope that helps solve / manage some errors! Continue your great work on this, it's proving to be a very useful tool!
Snes9x 1.51 support is definitely planned. As for the weird error message, the emulators lock the files while they're in use, so if i'm trying to read/write that same file, it'll throw an error (I try to trap those errors, but I'm sure I missed a few)
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Phil wrote:
Ah, strange. I wouldn't find it if you you weren't there. Maybe something more user-friendly? Also, the application refuses to save the file and there is an error.
See the end of this message for details on invoking 
just-in-time (JIT) debugging instead of this dialog box.

************** Exception Text **************
System.NullReferenceException: Object reference not set to an instance of an object.
   at MovieSplicer.Data.Formats.FCEU.getRLELength(TASMovieInput[]& input)
   at MovieSplicer.Data.Formats.FCEU.Save(String filename, TASMovieInput[]& input)
   at MovieSplicer.UI.frmSaveAs.btnSave_Click(Object sender, EventArgs e)
   at System.Windows.Forms.Control.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnClick(EventArgs e)
   at System.Windows.Forms.Button.OnMouseUp(MouseEventArgs mevent)
   at System.Windows.Forms.Control.WmMouseUp(Message& m, MouseButtons button, Int32 clicks)
   at System.Windows.Forms.Control.WndProc(Message& m)
   at System.Windows.Forms.ButtonBase.WndProc(Message& m)
   at System.Windows.Forms.Button.WndProc(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.OnMessage(Message& m)
   at System.Windows.Forms.Control.ControlNativeWindow.WndProc(Message& m)
   at System.Windows.Forms.NativeWindow.Callback(IntPtr hWnd, Int32 msg, IntPtr wparam, IntPtr lparam)


************** Loaded Assemblies **************
mscorlib
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/Microsoft.NET/Framework/v2.0.50727/mscorlib.dll
----------------------------------------
tas-movie-editor
    Assembly Version: 0.9.2.0
    Win32 Version: 0.9.2.0
    CodeBase: file:///G:/Timeattack%20en%20cours/Tas%20movie%20editor/tas-movie-editor.exe
----------------------------------------
System.Windows.Forms
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Windows.Forms/2.0.0.0__b77a5c561934e089/System.Windows.Forms.dll
----------------------------------------
System
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System/2.0.0.0__b77a5c561934e089/System.dll
----------------------------------------
System.Drawing
    Assembly Version: 2.0.0.0
    Win32 Version: 2.0.50727.42 (RTM.050727-4200)
    CodeBase: file:///C:/WINDOWS/assembly/GAC_MSIL/System.Drawing/2.0.0.0__b03f5f7f11d50a3a/System.Drawing.dll
----------------------------------------

************** JIT Debugging **************
To enable just-in-time (JIT) debugging, the .config file for this
application or computer (machine.config) must have the
jitDebugging value set in the system.windows.forms section.
The application must also be compiled with debugging
enabled.

For example:

<configuration>
    <system>
</configuration>

When JIT debugging is enabled, any unhandled exception
will be sent to the JIT debugger registered on the computer
rather than be handled by this dialog box.


So, what's going on?
Phil, could you send me the FCM you were using when you got this error? I can't reproduce it with any of the movie files I have here.
Emulator Coder, Former player
Joined: 10/2/2005
Posts: 563
Location: Toronto, Ontario
Ok, well it's been a while, and I'm sure there'll be another release (fingers crossed) soon that supports SNES9x 1.5+, fixes the error Phil has mentionned and maybe incorporates some new sexiness.
v0-12

- SMV::Fixed a bug that prevented loading of 5-player movie files
- VBM::Fixed reading / writing of L/R values
- ETC::Added a movie comparison module
- ETC::Added file-lock checks when saving (if an emulator has the file locked for writing, 
       the applicaiton will crash if you try to save) - thanks Halamantariel
The icon-view for input has been abandoned for the time being, as it just wasn't efficient (memory consumption-wise). This is being released as v0-12 as opposed to v0-11-1 since it actually contains new functionality (the input comparison thingy), as opposed to just being all bug fixes. Cheers :)
1 2
9 10 11
15 16